Skip to content

WIP: CORS-4265: Pass Firewall Rules Management Value to Cloud Provider #10064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: CORS-4265: Pass Firewall Rules Management Value to Cloud Provider #10064

wants to merge 1 commit into from
+27 −4

Conversation

@barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Nov 7, 2025

Set Enabled vs Disabled when the firewall rules should be managed by the cloud provider. Enabled in this case will indicate that the user has the permissions to manage firewall rules.

@barbacbd
CORS-4265: Pass Firewall Rules Management Value to Cloud Provider
0d8c66a 
Set Enabled vs Disabled when the firewall rules should be managed by the cloud
provider. Enabled in this case will indicate that the user has the permissions
to manage firewall rules.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2025 •
edited by openshift-ci bot
Loading

@barbacbd: This pull request references CORS-4265 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Set Enabled vs Disabled when the firewall rules should be managed by the cloud provider. Enabled in this case will indicate that the user has the permissions to manage firewall rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd barbacbd changed the title CORS-4265: Pass Firewall Rules Management Value to Cloud Provider WIP: CORS-4265: Pass Firewall Rules Management Value to Cloud Provider Nov 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@barbacbd
Copy link
Contributor Author

barbacbd commented Nov 7, 2025

Depends on:
#10018
kubernetes/cloud-provider-gcp#911

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-secureboot 0d8c66a link false /test e2e-gcp-secureboot
ci/prow/images 0d8c66a link true /test images
ci/prow/golint 0d8c66a link true /test golint
ci/prow/e2e-gcp-ovn-xpn 0d8c66a link false /test e2e-gcp-ovn-xpn
ci/prow/gcp-private 0d8c66a link false /test gcp-private
ci/prow/e2e-gcp-default-config 0d8c66a link false /test e2e-gcp-default-config
ci/prow/e2e-gcp-ovn-byo-vpc 0d8c66a link false /test e2e-gcp-ovn-byo-vpc
ci/prow/okd-scos-images 0d8c66a link true /test okd-scos-images
ci/prow/e2e-aws-ovn 0d8c66a link true /test e2e-aws-ovn
ci/prow/artifacts-images 0d8c66a link true /test artifacts-images
ci/prow/e2e-gcp-ovn 0d8c66a link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-xpn-dedicated-dns-project 0d8c66a link false /test e2e-gcp-xpn-dedicated-dns-project
ci/prow/unit 0d8c66a link true /test unit
ci/prow/e2e-gcp-custom-endpoints 0d8c66a link false /test e2e-gcp-custom-endpoints
ci/prow/govet 0d8c66a link true /test govet
ci/prow/okd-scos-e2e-aws-ovn 0d8c66a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-custom-dns 0d8c66a link false /test e2e-gcp-custom-dns

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 14, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barbacbd @openshift-ci-robot @openshift-merge-robot